Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sniper with automated pokelocation feed #1349

Merged
merged 11 commits into from
Jul 29, 2016
Merged

Sniper with automated pokelocation feed #1349

merged 11 commits into from
Jul 29, 2016

Conversation

5andr0
Copy link
Contributor

@5andr0 5andr0 commented Jul 29, 2016

See for yourself: Image

The client connects to an open source server made by @Ilses and me:
https://github.com/5andr0/PogoLocationFeeder/tree/master/PogoLocationFeeder

Right now it is crawling new pokemon locations from the discord channel #sniping
and sending them via json to the client. This can be improved to be a pokevision scraper etc

  "SnipeAtPokestops": true,
  "SnipeLocationServer": "localhost",
  "SnipeLocationServerPort": 16969,
  "UseSnipeLocationServer": true,
  "UseTransferIVForSnipe": false,
  "MinDelayBetweenSnipes": 20000,

There's a major bug in FarmPokestopsGPXTask.cs
where while (pokestopList.Any()) is never true because pokestops are already @ cooldown because of UseNearbyPokestopsTask. So all the calls in the loop are never executed (or 1 in 100). That's why i had to move the SnipePokemonTask call out which is then called more often. So i added the MinDelayBetweenSnipes.

More info on our wiki page: PogoLocationFeeder Wiki

Quick tutorial:

  • connect your discord account to the NecroBot server
  • start the PogoLocationFeeder to generate the config.json and enter your discord logins
  • start it again and run your necrobots. now wait until someone posts into #sniping

Can we find somebody to host the feeder so everybody can connect via ip+port?

Please help me to improve the feeder project. Todo: location database with continuous pokevision scraping. Or anything that helps to get locations.

Make sure you filled your PokemonToSnipe array:

"Pokemon": [
      "Dratini",
      "Magikarp",
      "Kangaskhan",
      "Eevee",
      "Charmander",
      "Snorlax",
      "Chansey",
      "Exeggutor",
      "Aerodactyl",
      "Vaporeon",
      "MrMime",
      "Magmar",
      "Dragonite",
      "Raichu",
      "Venusaur",
      "Slowbro",
      "Porygon",
      "Farfetchd",
      "Poliwrath",
      "Dragonair",
      "Charizard",
      "Blastoise",
      "Muk",
      "Gyarados",
      "Arcanine",
      "Machamp"
    ]

Fixed multithreading access issues to the snipeLocations. GPX pathing
has a flaw and never calls functions inside while (pokestopList.Any())
because all pokestops have been already looted by
UseNearbyPokestopsTask. So i moved the SnipeAtPokestops call out of it.
To prevent too many snipe lookups i added the minsnipedelay
@mich3lam
Copy link
Contributor

Wow, this is epic!

@Ilses
Copy link
Contributor

Ilses commented Jul 29, 2016

Before anyone asks, the bot will not be made public until one of the discord admins restricts the permissions to read-only on the #sniper channel. At that point, there will likely be another PR to change the default settings.

@carlanivans
Copy link

how do i add this to my bot...sorry noob here

@mich3lam
Copy link
Contributor

mich3lam commented Jul 29, 2016

@Ilses i am giving this a run now! :D
@carlanivans you should wait for a merge if you are not sure how to do it correctly

@carlanivans
Copy link

@mich3lamok thanks will do....btw been using this bot for days now and its amazing

@mich3lam
Copy link
Contributor

@carlanivans i am a lil bit confused about the:
{
"ServerId": 0,
"ServerChannel": "",
"DiscordToken": "",
"Port": 0
}
how do i retrieve those

@Ilses
Copy link
Contributor

Ilses commented Jul 29, 2016

@mich3lam Once again, that's the part we haven't made public. Our bot has too many permissions on the server, so waiting on an admin to cut those or it will get abused.

@mich3lam
Copy link
Contributor

mich3lam commented Jul 29, 2016

@Ilses Oh ahaha so i cannot really test it for now :<
but it compiles great, and is indeed an awesome addon!

@carlanivans
Copy link

@mich3lam @Ilses yeah making that public would make it go viral.....lets just wait for the combined release...right now my bot stops after every 30 mins and sniping shows no pokemon so im kinda sitting ducks here XD

@mich3lam
Copy link
Contributor

@carlanivans this actually stops the sniping from the setting.cs right ? these don't work anymore, i mean the ones in the bottom with coordinates

@carlanivans
Copy link

@mich3lam ahhhh ok thanks maybe those coordinates are dry now......but still no solution for my bot not working after 30 mins

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

I just added discord user login ability: 5andr0/PogoLocationFeeder@3724afa

@mich3lam
Copy link
Contributor

mich3lam commented Jul 29, 2016

so with this we can actually use it now? @5andr0
@carlanivans btw, the coords at the bottom of setting.cs are nests.. they always have pokemons there xd

@carlanivans
Copy link

@mich3lam i just manually go there and farm and use quick spin to get unbanned XD

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

yes @mich3lam it's ready to use, just pull my sniper branch from https://github.com/5andr0/NecroBot.git

@mich3lam
Copy link
Contributor

@5andr0 ye i have already compiled everything localy..
http://i.imgur.com/lkmxMko.png
too bad the bot isnt brining anythings to tets it xd

@carlanivans
Copy link

@5andr0 is there any way to add and compile without visual studio?

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

Use this server id: 206232715530338305 from PokemonGo Rare Hunting and channel high_iv_pokemon or rare_pokemon
Edit: i just added multichannel support

@mich3lam
Copy link
Contributor

@5andr0 i wanted to test it
made a random channel on my server
and this happens
http://i.imgur.com/RF9TOIc.png
why?

@mich3lam
Copy link
Contributor

i mean, it reads but the bot doesn't do anything with it

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

pm me on discord please @mich3lam
do you have these pokemons in the PokemonToSnipe necrobot config? it won't go sniping if not

@Marsinator
Copy link

maybe make him snipe only for pokemon with the best skill sets?
those can be found here: https://docs.google.com/spreadsheets/d/1I0Kt_QblThH2rf7vdZOC2L1Nuf7Y1xx68j_KYwfcpXc/htmlview?sle=true#

@carlanivans
Copy link

@5andr0 @mich3lam sorry for posting again but why is bot not working after 30 mins?

@hungvinh
Copy link

Sounds cool, I'm now in the discord group. How do I go about setting it up? Should I leave coordinates in the config.json for necrobot or remove them completely and leave "SnipeAtPokestops" as True?

@hima-n
Copy link

hima-n commented Jul 29, 2016

How to use it, i cant down it!

@LaurentiuBoblea
Copy link

wow this is awesome can't wait for the merge

@rayn21dev
Copy link

Pulled this into my bot, works great! Now if only I didn't have to restart the bot every 30 seconds.

@Bogenschuetze
Copy link

Bogenschuetze commented Jul 29, 2016

"SnipeLocationServer": "localhost",
"SnipeLocationServerPort": 16969,
"UseSnipeLocationServer": true,
"MinDelayBetweenSnipes": 5000,
Where do you set the channels?

@Ghawken
Copy link

Ghawken commented Jul 29, 2016

@5andr0 Thanks - seems to keep old sniping locations forever - 15 minutes remove doesnt seem to occur.? or maybe to long?

@jaskovic
Copy link

guys wehere i need to put this item in ;
{
"ServerChannels": [
"sniping",
"high_iv_pokemon",
"rare_pokemon"
],
"DiscordToken": "",
"Port": 16969,
"useToken": false,
"DiscordUser": "discord_mail",
"DiscordPassword": "discord_pwd"
}

??

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

@jaskovic PogoLocationFeeder -> config.json

Won't snipe pokemons with unknown iv
@miraclesuki
Copy link

Hi,

I was compiled the new branch of incasesensitive, no more sniper info from the console.
Any Idea? Thanks!!

http://i65.tinypic.com/34zj2nc.jpg

@5andr0
Copy link
Contributor Author

5andr0 commented Jul 29, 2016

@miraclesuki no idea, pm me on discord

@l3uddz
Copy link
Contributor

l3uddz commented Jul 29, 2016

This works really well. Good job. Hope it gets merged.

@nenko91
Copy link

nenko91 commented Jul 29, 2016

@5andr0 where to find you in discord? ^^

@Ghawken
Copy link

Ghawken commented Jul 29, 2016

Hi. thanks for the work on this

why does it scan locations without a selected pokemon?

(eg. Missingto not included in snipe pokemon list, but Bot snipes locations with Missingto - doesnt find any - but shouldn't it not save the location data for unselected pokemon id?)

@Lastnet0709
Copy link

help :(

http://pastebin.com/b1t9Sbdn config.json necrobot

@maximegmd maximegmd merged commit 37c30d1 into NecronomiconCoding:master Jul 29, 2016
@rankin1981
Copy link

When ever i add

"SnipeAtPokestops": true,
"SnipeLocationServer": "localhost",
"SnipeLocationServerPort": 16969,
"UseSnipeLocationServer": true,
"UseTransferIVForSnipe": false,
"MinDelayBetweenSnipes": 20000,

To necro bot config.json
and start Necro bot those lines get removed

@nenko91
Copy link

nenko91 commented Jul 29, 2016

I've got NecroBot working and PogoLocationFeeder working, but can't connect them. My necrobot config file doesn't update with the server options. I've read that I have to "build branch here:

https://github.com/5andr0/NecroBot/tree/sniper". Could someone explain how to do it or give some tips?

@Ilses
Copy link
Contributor

Ilses commented Jul 29, 2016

See our wiki page for a configuration tutorial.

@skupfer
Copy link
Contributor

skupfer commented Jul 29, 2016

I used the fork from @5andr0 before but it doesn't has the 30min fix included... Since I am lazy today I decided to give NecroBot a try again (still using prefork-modified^^).

With @5andr0 's fork the Sniperfunction was working perfectly fine. After this got merged in I pulled the latest commit be2f597 and it rarely snipes even if the PogoLocationFeeder is getting massively filled ...

Using the same settings I would argue its an setting-related. Haven't found out yet what the issue is :-/ but I guess it could be related to changes after this merge to sniper related tasks...

@nenko91
Copy link

nenko91 commented Jul 29, 2016

@Ilses The tutorial says that my necrobot Config file should contain these:
"MinPokeballsToSnipe": 0,
"SnipeLocationServer": "",
"SnipeLocationServerPort": ,
"UseSnipeLocationServer": true,
"UseTransferIVForSnipe": false,
"MinDelayBetweenSnipes": 5000,

but it doesn't

@Ilses
Copy link
Contributor

Ilses commented Jul 29, 2016

@nenko91 You need to be on the latest version. They should automagically be added as config options the next time you run NecroBot.

@skupfer GTX logic doesn't give sniping enough time right now. You can modify it, or use non-GPX.

@nenko91
Copy link

nenko91 commented Jul 29, 2016

@Ilses I am on the latest version

@skupfer
Copy link
Contributor

skupfer commented Jul 29, 2016

@Ilses Already on non-GPX here

@hungvinh
Copy link

How exactly do I compile necrobot to use with this?

@hima-n
Copy link

hima-n commented Jul 30, 2016

waiting for @hungvinh

@nenko91
Copy link

nenko91 commented Jul 30, 2016

When I download the source code and open the solution it doesn't load PokemonGo.RocketAPI and it says it's unavailable and I can't find it in the folders either. How do I fix that? Is it my VS?
The release version works fine, but can't set it to work with PogoLocationFeeder

@ghost
Copy link

ghost commented Jul 30, 2016

@nenko91 You need to download the API separately and put it in the FeroxRev folder.

@nenko91
Copy link

nenko91 commented Jul 30, 2016

@mvegter197 Cheers, man! Been headbanging since yesterday over that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.